First batch of followups to #1650 #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 28.81% 28.81%
=======================================
Files 139 139
Lines 8139 8139
=======================================
Hits 2345 2345
Misses 5542 5542
Partials 252 252
Continue to review full report at Codecov.
|
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
mattmoor
approved these changes
Mar 25, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* First batch of followups to sigstore#1650 Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Fix few typos. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * remove some unnecessary cruft since the actions handle them. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * kubectl apply vs. create Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * try harder Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * registry before installations. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Remove trying with 1.23 which might have different job retry behaviour. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Address PR followups from #1650 first batch.
Ticket Link
Fixes
Release Note