Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intermediate CA certificate pool for Fulcio #1749

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

haydentherapper
Copy link
Contributor

This separates roots and intermediates from the TUF targets. This will
be used to configure the default intermediate certificates when none are
found. In particular, this will be used by verify-blob when fetching an
entry from Rekor.

An intermediate CA certificate will be added to the v3 TUF root.

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Ticket Link

Fixes

Release Note


@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #1749 (303abb0) into main (cf03ef2) will increase coverage by 0.03%.
The diff coverage is 35.55%.

@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
+ Coverage   29.67%   29.71%   +0.03%     
==========================================
  Files         142      142              
  Lines        8482     8529      +47     
==========================================
+ Hits         2517     2534      +17     
- Misses       5694     5721      +27     
- Partials      271      274       +3     
Impacted Files Coverage Δ
cmd/cosign/cli/fulcio/fulcio.go 25.00% <0.00%> (-0.61%) ⬇️
cmd/cosign/cli/verify/verify_blob.go 10.49% <0.00%> (ø)
cmd/cosign/cli/fulcio/fulcioroots/fulcioroots.go 36.50% <41.02%> (+7.56%) ⬆️
pkg/cosign/verify.go 18.48% <0.00%> (+0.03%) ⬆️
pkg/cosign/tlog.go 5.79% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf03ef2...303abb0. Read the comment docs.

This separates roots and intermediates from the TUF targets. This will
be used to configure the default intermediate certificates when none are
found. In particular, this will be used by verify-blob when fetching an
entry from Rekor.

An intermediate CA certificate will be added to the v3 TUF root.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@dlorenc dlorenc merged commit 3047220 into sigstore:main Apr 13, 2022
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 13, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
This separates roots and intermediates from the TUF targets. This will
be used to configure the default intermediate certificates when none are
found. In particular, this will be used by verify-blob when fetching an
entry from Rekor.

An intermediate CA certificate will be added to the v3 TUF root.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper deleted the intermediate-fulcio branch November 17, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants