Implement identities, fix bug in webhook validation. #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
vaikas
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
+ Coverage 30.17% 30.54% +0.37%
==========================================
Files 143 143
Lines 8607 8655 +48
==========================================
+ Hits 2597 2644 +47
- Misses 5710 5711 +1
Partials 300 300
Continue to review full report at Codecov.
|
…e specified. Fix the actions yaml file typo. missing actual run, doh. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
mattmoor
reviewed
Apr 14, 2022
|
|
||
| // Identities is an array of Identity (Subject, Issuer) matchers that have | ||
| // to be met for the signature to ve valid. | ||
| // Supercedes CertEmail / CertOidcIssuer |
There was a problem hiding this comment.
Can we change those to pass a []v1alpha1.Identity?
There was a problem hiding this comment.
Thought about it, but did not want to change them because they would match other things than email and that would be a change in behaviour. So, I'd rather not do that as part of this PR.
Comment on lines
+190
to
+191
| if regex, err := regexp.Compile(identity.Issuer); err != nil { | ||
| return nil, fmt.Errorf("malformed issuer in identity: %s : %w", identity.Issuer, err) |
There was a problem hiding this comment.
We should check in the webhook that these are valid regex
There was a problem hiding this comment.
Yeah, I'll do that in a follow up PR and add tests for them, ok?
Comment on lines
+203
to
+206
| regex, err := regexp.Compile(identity.Subject) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("malformed subject in identity: %s : %w", identity.Subject, err) | ||
| } |
mattmoor
approved these changes
Apr 14, 2022
mtrmac
reviewed
Apr 22, 2022
| // Identities is an array of Identity (Subject, Issuer) matchers that have | ||
| // to be met for the signature to ve valid. | ||
| // Supercedes CertEmail / CertOidcIssuer | ||
| Identities []v1alpha1.Identity |
There was a problem hiding this comment.
This causes every user of pkg/cosign to depend on k8s; updating to a recent Cosign version thus adds 1.157 million lines of code.
Please consider some other API design.
vaikas
added a commit
to vaikas/cosign
that referenced
this pull request
Apr 22, 2022
unnecessary k8s libraries. Brought up as an issue that was merged in: sigstore#1759 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
vaikas
added a commit
to vaikas/cosign
that referenced
this pull request
Apr 22, 2022
unnecessary k8s libraries. Brought up as an issue that was merged in: sigstore#1759 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
dlorenc
pushed a commit
that referenced
this pull request
Apr 22, 2022
unnecessary k8s libraries. Brought up as an issue that was merged in: #1759 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Implement identites, fix bug in webhook validation. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * fix lint. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Fix the invalid test that was incorrectly assuming identities can't be specified. Fix the actions yaml file typo. missing actual run, doh. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…1790) unnecessary k8s libraries. Brought up as an issue that was merged in: sigstore#1759 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Ticket Link
Fixes
Release Note