-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuf: add debug info if tuf update fails #1766
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
+ Coverage 31.26% 31.39% +0.13%
==========================================
Files 144 144
Lines 8830 8879 +49
==========================================
+ Hits 2761 2788 +27
- Misses 5741 5755 +14
- Partials 328 336 +8
Continue to review full report at Codecov.
|
pkg/cosign/tuf/client.go
Outdated
@@ -360,6 +383,12 @@ func embeddedLocalStore() (client.LocalStore, error) { | |||
return local, nil | |||
} | |||
|
|||
type signedMeta struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a struct defined in go-tuf we can use? For timestamp, can we use https://github.com/theupdateframework/go-tuf/blob/5b81b7e5604bfae2f0dcecd041e2e44f0128c992/data/types.go#L310?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a private struct, not exported in go-tuf. I don't really want to condition on metadata type though, and all metadata defines these three.
Signed-off-by: Asra Ali <asraa@google.com>
* add debug info for tuf update fail Signed-off-by: Asra Ali <asraa@google.com> * move debugging funcs to top Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali asraa@google.com
Summary
Ticket Link
Related sigstore/root-signing#166
Release Note
Example output (I manually edited one file so sigs would fail):