fix: more informative error #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the attach attestation command with empty file input the cli returns hard to understand output like: ``` file name too long Using payload from: filename.json Error: unexpected end of JSON input main.go:46: error during command execution: unexpected end of JSON input ``` By some investigation I found out that attestation file was empty, yes this is a user-error, so I recon it could be more informative as it throws the error while parsing the input making the real error a bit shaded. Signed-off-by: ybelMekk <youssef.bel.mekki@nav.no>
dlorenc
approved these changes
Apr 21, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
When running the attach attestation command with empty file input the cli returns hard to understand output like: ``` file name too long Using payload from: filename.json Error: unexpected end of JSON input main.go:46: error during command execution: unexpected end of JSON input ``` By some investigation I found out that attestation file was empty, yes this is a user-error, so I recon it could be more informative as it throws the error while parsing the input making the real error a bit shaded. Signed-off-by: ybelMekk <youssef.bel.mekki@nav.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command used:
cosign attach attestation --attestation filename.json imageWhen running the attach attestation command with empty file payload the cli returns a hard to understand output:
By some investigation I found out that attestation file was empty, yes this is a user-error, so I recon it could be more informative as it throws the error while parsing the input making the real error a bit shaded.
Summary
Gives the user a more informative error when providing empty command input.
Ticket Link
Fixes
Release Note