Add auth flow option to KeyOpts. #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an option for callers to manually select the fulcio auth flow to go through. This allows callers that don't fit into the default heuristic to have some control over how cosign is invoked. For now, this is only added as a KeyOpt and not a flag, since this is currently only needed by tools calling the cosign libraries, not cosign itself. Flags can be added on later if needed. This change should not have any impact on existing cosign behavior. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
- Coverage 33.02% 33.01% -0.02%
==========================================
Files 147 147
Lines 9347 9350 +3
==========================================
Hits 3087 3087
- Misses 5906 5909 +3
Partials 354 354
Continue to review full report at Codecov.
|
dlorenc
approved these changes
May 2, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This change adds an option for callers to manually select the fulcio auth flow to go through. This allows callers that don't fit into the default heuristic to have some control over how cosign is invoked. For now, this is only added as a KeyOpt and not a flag, since this is currently only needed by tools calling the cosign libraries, not cosign itself. Flags can be added on later if needed. This change should not have any impact on existing cosign behavior. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds an option for callers to manually select the fulcio
auth flow to go through. This allows callers that don't fit into the
default heuristic to have some control over how cosign is invoked.
For now, this is only added as a KeyOpt and not a flag, since this is
currently only needed by tools calling the cosign libraries, not cosign
itself. Flags can be added on later if needed.
This change should not have any impact on existing cosign behavior.
Because there are no unit tests for
fulcio.NewSignerat the moment,this is difficult to test in a way that isn't trivial. This is probably a good
target to improve coverage as part of #1385
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
Fixes #1785
Release Note