Validate tlog entry when verifying signature via public key. #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @asraa |
Previously, when signatures were validated via public key, we only checked for the existence of the tlog, but didn't actually validate the entry. This refactors the code to ensure both cert + public paths go through the same tlog entry validation. Signed-off-by: Billy Lynch <billy@chainguard.dev>
asraa
reviewed
May 4, 2022
| SigVerifier: sv, | ||
| RekorClient: mClient, | ||
| }); err == nil || !strings.Contains(err.Error(), "verifying inclusion proof") { | ||
| // TODO(wlynch): This is a weak test, since this is really failing because |
There was a problem hiding this comment.
It looks like trillian makes some fake inclusion proofs https://github.com/google/trillian/blob/3d7922afdce9fd0144e16aae08bea061c0ad1aee/merkle/logverifier/log_verifier_test.go#L45 for testing -- maybe we can do that?
asraa
approved these changes
May 4, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…e#1833) Previously, when signatures were validated via public key, we only checked for the existence of the tlog, but didn't actually validate the entry. This refactors the code to ensure both cert + public paths go through the same tlog entry validation. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when signatures were validated via public key, we only
checked for the existence of the tlog, but didn't actually validate the
entry. This refactors the code to ensure both cert + public paths go
through the same tlog entry validation.
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
Fixes #1816
Release Note