Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-blob: bundle should work independently and respect --output-certificate and --output-signature #2016

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented Jun 22, 2022

Fixes #1821
Fixes #2005

Signed-off-by: Furkan furkan.turkal@trendyol.com

cc @priyawadhwa

Summary

$ COSIGN_EXPERIMENTAL=true ./cosign sign-blob /dev/null --output-certificate foo.pem --output-signature foo.sig --bundle foo.bundle

Bundle wrote in the file foo.bundle
Signature wrote in the file foo.sig
Certificate wrote in the file foo.pem

Ticket Link

Fixes

Release Note

Fixed an issue where --bundle flag does not work independently with `--output-certificate` and `--output-signature` in sign-blob 

Fixes sigstore#1821
Fixes sigstore#2005

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #2016 (36a4785) into main (76184c4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.02%     
==========================================
  Files         127      127              
  Lines        7422     7425       +3     
==========================================
  Hits         1942     1942              
- Misses       5225     5228       +3     
  Partials      255      255              
Impacted Files Coverage Δ
cmd/cosign/cli/sign/sign_blob.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76184c4...36a4785. Read the comment docs.

@priyawadhwa
Copy link
Contributor

Thanks for fixing this @Dentrax !

@dlorenc dlorenc merged commit 4e282fd into sigstore:main Jun 23, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants