Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Result in Vulnerability Attestation to interface{} #2096

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Change Result in Vulnerability Attestation to interface{} #2096

merged 1 commit into from
Jul 26, 2022

Conversation

knqyf263
Copy link
Contributor

Summary

Please feel free to close the PR if there is any requirement on Result in the Vulnerability Scan Record Attestation.

Close #2095

Release Note

None

Documentation

None

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2096 (8f9d314) into main (3e49138) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2096   +/-   ##
=======================================
  Coverage   26.33%   26.33%           
=======================================
  Files         129      129           
  Lines        7564     7564           
=======================================
  Hits         1992     1992           
  Misses       5317     5317           
  Partials      255      255           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dlorenc
Copy link
Member

dlorenc commented Jul 23, 2022

I think this is fine, do we need to change the docs anywhere?

@knqyf263
Copy link
Contributor Author

It is mentioned as object. I think it is fine. Do you want to change it to any or something like that?

**scanner.result** object

jdolitsky added a commit to jdolitsky/policy-controller that referenced this pull request Jul 25, 2022
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky added a commit to jdolitsky/policy-controller that referenced this pull request Jul 25, 2022
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky added a commit to jdolitsky/policy-controller that referenced this pull request Jul 25, 2022
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky added a commit to jdolitsky/policy-controller that referenced this pull request Jul 25, 2022
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@dlorenc dlorenc merged commit e0547cf into sigstore:main Jul 26, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Jul 26, 2022
@knqyf263 knqyf263 deleted the vuln_attestation_result branch July 26, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vulnerability attestation: change Result to interface{}
3 participants