Air gap support #2299
Merged
Air gap support #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2299 +/- ##
=======================================
Coverage 30.48% 30.48%
=======================================
Files 136 136
Lines 8384 8384
=======================================
Hits 2556 2556
Misses 5494 5494
Partials 334 334
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Is this ready for review? |
|
I want to add the e2e tests for it. |
|
ho hum, I see we need to add the required tests because I added a new matrix segment for this to be considered passing. |
znewman01
previously approved these changes
Nov 7, 2022
|
thanks @znewman01 ! Yeah, all the "real" work was in upstreams :) Here's just tests. |
dlorenc
previously approved these changes
Nov 8, 2022
bobcallaway
reviewed
Nov 9, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
cpanato
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use newer version of theupdateframework/go-tuf, sigstore/sigstore
theupdateframework/go-tuf#397
sigstore/sigstore#715
This allows one to specify a local filesystem as a TUF remote so there's no network calls related to TUF.
Release Note
Documentation