Refactor sign command #2388
Merged
Refactor sign command #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't have to pass in a bunch of arguments, should also make writing tests easier. Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
refactor-sign
branch
from
4be865f to
3084233
Compare
Codecov Report
@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
- Coverage 30.12% 30.12% -0.01%
==========================================
Files 136 136
Lines 8451 8452 +1
==========================================
Hits 2546 2546
- Misses 5574 5575 +1
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
asraa
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't have to pass in a bunch of arguments, should also make writing tests easier.
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Summary
Release Note
Documentation