Add support for recording creation timestamp for cosign attest #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
previously approved these changes
Jul 26, 2024
Contributor
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Thanks!
fyi @jonjohnsonjr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3797 +/- ##
==========================================
- Coverage 40.10% 37.67% -2.44%
==========================================
Files 155 201 +46
Lines 10044 12444 +2400
==========================================
+ Hits 4028 4688 +660
- Misses 5530 7180 +1650
- Partials 486 576 +90 ☔ View full report in Codecov by Sentry. |
Contributor
|
can you rerun |
auto-merge was automatically disabled
July 29, 2024 07:14
Head branch was pushed to by a user without write access
added 2 commits
July 29, 2024 09:17
Signed-off-by: Zsolt Horvath <zsolte@gmail.com> Signed-off-by: Zsolt Horvath <zsolt.horvath@real-digital.de>
Signed-off-by: Zsolt Horvath <zsolt.horvath@real-digital.de>
Contributor
Author
I have made a change so attest.go and cosign_attest.md has the same example line at the top, after this ./cmd/help/verify.sh should complete without an error |
haydentherapper
approved these changes
Jul 29, 2024
kipz
pushed a commit
to kipz/cosign
that referenced
this pull request
Oct 21, 2024
…ore#3797) * add support for recording creation timestamp for cosign attest Signed-off-by: Zsolt Horvath <zsolte@gmail.com> Signed-off-by: Zsolt Horvath <zsolt.horvath@real-digital.de> * Fix cosign attest example in doc/cosign_attest.md Signed-off-by: Zsolt Horvath <zsolt.horvath@real-digital.de> --------- Signed-off-by: Zsolt Horvath <zsolte@gmail.com> Signed-off-by: Zsolt Horvath <zsolt.horvath@real-digital.de> Co-authored-by: Zsolt Horvath <zsolt.horvath@real-digital.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cosign sign, leaving the timestamp empty for attestations. It is a huge problem for oci registries allowing automatic cleanup policies as they won't be able to tell the creation time. GitLab for example is reporting 23 years of age for uploaded attestationsRelease Note
cosign attestDocumentation
attach an attestation to a container image and honor the creation timestamp of the signature
References