SBOM support in "cosign attach" and "cosign download sbom". #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
commented
Jun 24, 2021
cmd/cosign/cli/attach/sbom.go
Outdated
| return err | ||
| } | ||
| // TODO: Fix me. | ||
| m.Config.MediaType = "application/vnd.sbom.config.v1+json" |
There was a problem hiding this comment.
@jonjohnsonjr what do i put here
There was a problem hiding this comment.
Is there any useful configuration you'd want to put in there?
There was a problem hiding this comment.
No. I could eventually see the need for multiple SBOMs (one for the overall image, then some for sub-parts), but that would get tackled via annotations on each layer to indicate which portion of the image the SBOM is intended to cover.
dlorenc
force-pushed
the
sbom
branch
3 times, most recently
from
f5f1877
to
784c153
Compare
sambhav
reviewed
Jun 26, 2021
cmd/cosign/cli/attach/sbom.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| m.Config.MediaType = "text/spdx" |
There was a problem hiding this comment.
Is it possible to support both cyclonedx and spdx here?
dlorenc
force-pushed
the
sbom
branch
2 times, most recently
from
e1b1765
to
ebd4d92
Compare
This is ready! Signed-off-by: Dan Lorenc <dlorenc@google.com>
dlorenc
changed the title
|
Dropping the WIP, this is ready to go! |
priyawadhwa
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Lorenc dlorenc@google.com