fix nil pointer deref in cli/upload.BlobCmd #563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with the
cosign
cli and found that callingcosign upload blob ...
with an image address but without any-f
arguments leads to a nil pointer dereference. This patch adds a check that at least one file was provided.The underlying cause is that calling
cremote.UploadFiles
with an emptyfiles
list never sets thevar img v1.Image
within and thus the returneddgstr
isnil
, I believe?