Several cleanups to SignCmd
#674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use the `DefaultRegistryClientOpts` which is a superset of what we use now, but sets `User-Agent`, 2. Pre-allocate the `toSign` array to have space for at least the number of images passed in (only more if recursive), 3. Use `Digest` to access the initial hash, which saves a `remote.Get` when we're passed a digest and non-recursive (at the cost of two requests when we are passed a tag in recursive mode), 4. Change the way we iterate over `toSign` to be conventional (not sure why we were doing it the other way before, but I'm guessing the two loops we now have were previously fused). Signed-off-by: Matt Moore <mattomata@gmail.com>
dekkagaijin
reviewed
Sep 15, 2021
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | ||
| remote.WithContext(ctx), | ||
| } | ||
| remoteOpts := DefaultRegistryClientOpts(ctx) |
dekkagaijin
reviewed
Sep 15, 2021
|
|
||
| var toSign []name.Digest | ||
| toSign := make([]name.Digest, 0, len(imgs)) |
There was a problem hiding this comment.
unnecessary, but not worse than what exists. @jonjohnsonjr assures me that the number of recursive images is unbounded
dekkagaijin
reviewed
Sep 15, 2021
| @@ -304,9 +304,7 @@ func SignCmd(ctx context.Context, ko KeyOpts, annotations map[string]interface{} | |||
| } | |||
| } | |||
|
|
|||
| for len(toSign) > 0 { | |||
There was a problem hiding this comment.
good catch, didn't simplify this after refining the recursion
dekkagaijin
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultRegistryClientOptswhich is a superset of what we use now, but setsUser-Agent,toSignarray to have space for at least the number of images passed in (only more if recursive),Digestto access the initial hash, which saves aremote.Getwhen we're passed a digest and non-recursive (at the cost of two requests when we are passed a tag in recursive mode),toSignto be conventional (not sure why we were doing it the other way before, but I'm guessing the two loops we now have were previously fused).Signed-off-by: Matt Moore mattomata@gmail.com