Define interfaces for reasoning about signed images. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts to layout our augmented interfaces for reasoning about signed images and indices. The next step will be to try and shoe-horn some of the implementation of these that we currently use into a new `internal/oci/remote` package. A couple (seemingly) superficial things about how this is set up: 1. The layout of this reflects the layout of GGCR. The interfaces there are in `pkg/v1`, and implementations of them in `pkg/v1/<name>`. 2. By embedding `v1.Image` instead of *just* surfacing the higher-level things, we enable folks to `remote.Write` and `tarball.Write` the signatures, which feels useful. None of this stuff is carved in stone, so we'll see how far off we are as we start to use this first-stab for realz. Related: sigstore#666 Signed-off-by: Matt Moore <mattomata@gmail.com>
dekkagaijin
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to layout our augmented interfaces for reasoning about signed images and indices. The next step will be to try and shoe-horn some of the implementation of these that we currently use into a new
internal/oci/remotepackage.A couple (seemingly) superficial things about how this is set up:
pkg/v1, each in their own file, and implementations of them inpkg/v1/<name>.v1.Imageinstead of just surfacing the higher-level things, we enable folks toremote.Writeandtarball.Writethe signatures, which feels useful.oci.gointo a more aptly namedmediatypes.goNone of this stuff is carved in stone, so we'll see how far off we are as we start to use this first-stab for realz.
Signed-off-by: Matt Moore mattomata@gmail.com
Ticket Link
Related: #666
Release Note