Start to flesh out Signatures and internal/oci/remote
#699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with `cosign.FetchSignaturesForImageDigest`, I am starting to peel out some of the existing logic, and try to define useful interfaces within `internal/oci.Signatures` and implement them in `internal/oci/remote.Signatures`. This is still somewhat rough in parts, so I suspect that as we build it up, we will iterates on parts of it. Signed-off-by: Matt Moore <mattomata@gmail.com>
mattmoor
commented
Sep 16, 2021
dekkagaijin
reviewed
Sep 16, 2021
Signed-off-by: Matt Moore <mattomata@gmail.com>
Signed-off-by: Matt Moore <mattomata@gmail.com>
dekkagaijin
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
cosign.FetchSignaturesForImageDigest, I am starting to peel out some of the existing logic, and try to define useful interfaces withininternal/oci.Signaturesand implement them ininternal/oci/remote.Signatures.This is still somewhat rough in parts, so I suspect that as we build it up, we will iterates on parts of it.
Signed-off-by: Matt Moore mattomata@gmail.com
Ticket Link
Related: #666
Release Note