Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test to the cosigned e2e suite with multiple keys. #943

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Oct 23, 2021

This isn't great, but works. This adds two non-used keys to the list
on top of the actual signing key. This would have failed without #942.

Signed-off-by: Dan Lorenc lorenc.d@gmail.com

Summary

Ticket Link

Fixes

Release Note


@dlorenc
Copy link
Member Author

dlorenc commented Oct 23, 2021

Ref #942

@dlorenc dlorenc force-pushed the twokeystest branch 6 times, most recently from 506670c to 1ccab20 Compare October 23, 2021 21:10
@dlorenc dlorenc changed the title Super rough draft at adding a cosign e2e test that will test multiple… Adds a test to the cosigned e2e suite with multiple keys. Oct 23, 2021
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are “twokeys” and “manykeys” supposed to be the same?

Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it improves the current e2e test coverage ❤️

This isn't great, but works. This adds two non-used keys to the list
on top of the actual signing key. This would have failed without sigstore#942.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
@dlorenc
Copy link
Member Author

dlorenc commented Nov 12, 2021

Are “twokeys” and “manykeys” supposed to be the same?

Fixed!

@dlorenc dlorenc merged commit 89f3590 into sigstore:main Nov 12, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants