Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs) updates hardware token docs #128

Merged
merged 3 commits into from
May 9, 2023
Merged

chore(docs) updates hardware token docs #128

merged 3 commits into from
May 9, 2023

Conversation

ChrisJBurns
Copy link
Contributor

This aims to deprecate https://github.com/sigstore/cosign/blob/main/TOKENS.md

Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com

@ChrisJBurns
chore(docs) updates hardware token docs
04c247c 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Apr 16, 2023 •
edited
Loading

✅ Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 93c3d54
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/644406e55706d60008c3961f
😎 Deploy Preview https://deploy-preview-128--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ChrisJBurns
Copy link
Contributor Author

This is just a carbon copy of what is in https://github.com/sigstore/cosign/blob/main/TOKENS.md.

However, a thing to note is the image that is being used as a reference in the doc is from dlorenc-vmtest2. Do we have an official test image that we can use for examples?

ltagliaferri
ltagliaferri requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just changed a lot of the dlorenc usernames to generic user, so I would just revert those back

content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
content/en/cosign/hardware-based-tokens.md Outdated Show resolved Hide resolved
@ChrisJBurns
Renames image user
2a67fb4 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
Corrents usage of Cosign
93c3d54 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
Copy link
Contributor Author

@ltagliaferri Have pushed up the changes based on your PR comments.

@ltagliaferri ltagliaferri merged commit aecdc8d into sigstore:main May 9, 2023
@ChrisJBurns ChrisJBurns deleted the hardware-tokens-docs branch May 9, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltagliaferri ltagliaferri ltagliaferri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisJBurns @ltagliaferri