-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds keyless signatures documentation #56
Conversation
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@znewman01 Here's the I've just copied and pasted the markdown, not sure if you wanted a refactor of the content itself? I assumed that the content in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a wholesale migration is a good start
CC @ltagliaferri for approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments for changes, the most important ones are the ones around the GA as we should avoid merging in outdated info here.
@ltagliaferri Addressed PR comments 👍 |
content/en/cosign/keyless.md
Outdated
|
||
### Custom root Cert | ||
|
||
You can override the public good instance root CA using the environment variable `SIGSTORE_ROOT_FILE`, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this section with the flags for the CT and Rekor keys too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to figure out what those flags are ... will update when committed and pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have had a look at the current cosign
that I've got locally from brew
and I can't see any keys for rekor when doing cosign sign -help
. Which keys are you referencing exactly? I can quickly put them in if possible
@haydentherapper I'll have to spend a bit more time on this PR. I've only copied and pasted the content from the existing KEYLESS.md in the cosign repo, so am unsure on the details of keyless signatures. Additionally, I've not actually run anything locally around keyless signatures so I'll have to do a bit of learning in order to fill the gaps, as well as giving it a try locally to get the latest updates for output. |
I think it's fine to copy this over as-is and not add content, but I would remove outdated content. |
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@haydentherapper have pushed up changes that (I think) addresses some of your comments. I've resolved them so you can see which ones I've attempted to resolve and left the others unresolved with a comment as they will take a bit more time for me to do. |
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@haydentherapper @znewman01 @ltagliaferri Have pushed some newer changes, made a quick start at the top using Lastly, I didn't get this in my output for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you signed up for "copy paste a markdown file between two repos" and got a heck of a lot more than that, thanks!
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@znewman01 Just pushed up amendments, let me know when you get a chance 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks so much for this! Docs are really important for helping users navigate what we often take for granted 😄
@znewman01 No problems, glad to finally get it done 😄 I'll submit the deprecation PR for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline
Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com