Skip to content

Commit

Permalink
Fix the k8s subject parsing. (#254)
Browse files Browse the repository at this point in the history
This got dropped unintentionally during the interface refactor in #218 and #220.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
  • Loading branch information
dlorenc authored Dec 1, 2021
1 parent 7f42ba5 commit 7add627
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/ca/googleca/v1/googleca.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ func (c *CertAuthorityService) CreateCertificate(ctx context.Context, subj *chal
privca = spiffeSubject(subj.Value)
case challenges.GithubWorkflowValue:
privca = githubWorkflowSubject(subj.Value)
case challenges.KubernetesValue:
privca = KubernetesSubject(subj.Value)
}

pubKeyBytes, err := cryptoutils.MarshalPublicKeyToPEM(subj.PublicKey)
Expand Down
2 changes: 2 additions & 0 deletions pkg/ca/googleca/v1beta1/googleca.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ func (c *CertAuthorityService) CreateCertificate(ctx context.Context, subj *chal
privca = spiffeSubject(subj.Value)
case challenges.GithubWorkflowValue:
privca = githubWorkflowSubject(subj.Value)
case challenges.KubernetesValue:
privca = KubernetesSubject(subj.Value)
}

pubKeyBytes, err := cryptoutils.MarshalPublicKeyToPEM(subj.PublicKey)
Expand Down

0 comments on commit 7add627

Please sign in to comment.