Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub OCI requires implementation for fulcio CA #183

Closed
lukehinds opened this issue Sep 13, 2021 · 0 comments · Fixed by #184
Closed

GitHub OCI requires implementation for fulcio CA #183

lukehinds opened this issue Sep 13, 2021 · 0 comments · Fixed by #184

Comments

@lukehinds
Copy link
Member

lukehinds commented Sep 13, 2021

PR #180 missed the modular CA implementation and does not work for fulcioca.

from a cursory look we need a challenges.GithubWorkflowValue to manage subject.Value

switch subject.TypeVal {
case challenges.EmailValue:
cert.EmailAddresses = []string{subject.Value}
case challenges.SpiffeValue:
challengeURL, err := url.Parse(subject.Value)
if err != nil {
return "", nil, err
}
cert.URIs = []*url.URL{challengeURL}
}

cc @mattmoor

mattmoor added a commit to mattmoor/fulcio that referenced this issue Sep 14, 2021
mattmoor added a commit to mattmoor/fulcio that referenced this issue Sep 14, 2021
Fixes: sigstore#183
Signed-off-by: Matt Moore <mattomata@gmail.com>
lukehinds pushed a commit that referenced this issue Sep 14, 2021
Fixes: #183
Signed-off-by: Matt Moore <mattomata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant