Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #194

Closed
Tracked by #191
lukehinds opened this issue Oct 5, 2021 · 0 comments · Fixed by #219
Closed
Tracked by #191

Integration tests #194

lukehinds opened this issue Oct 5, 2021 · 0 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@lukehinds
Copy link
Member

Now that d643aae is available, we need some integration test coverage.

@lukehinds lukehinds added the bug Something isn't working label Oct 5, 2021
@lukehinds lukehinds mentioned this issue Oct 5, 2021
4 tasks
mattmoor added a commit to mattmoor/fulcio that referenced this issue Oct 27, 2021
There are several parts to this change:
1. Implement a new `ephemeralca` that just generates an in-memory certificate,
1. Rename `pkg/ca/pkcs11ca` to `pkg/ca/x509ca` since it had nothing `PKCS11` specific (shared with `ephemeralca` logic),
1. Add support for Kubernetes OIDC via Service Account Projected Volumes,
1. Have the KinD e2e test use `ephemeralca` and `cosign sign` an image.

I can split some of these pieces apart, but wanted to get this all working end-to-end, since a key goal was enabling e2e testing on KinD.

This follows a lot of the ideas from: https://github.com/mattmoor/kind-oidc

Related: sigstore#212
Fixes: sigstore#194

Signed-off-by: Matt Moore <mattomata@gmail.com>
dlorenc pushed a commit that referenced this issue Oct 28, 2021
There are several parts to this change:
1. Implement a new `ephemeralca` that just generates an in-memory certificate,
1. Rename `pkg/ca/pkcs11ca` to `pkg/ca/x509ca` since it had nothing `PKCS11` specific (shared with `ephemeralca` logic),
1. Add support for Kubernetes OIDC via Service Account Projected Volumes,
1. Have the KinD e2e test use `ephemeralca` and `cosign sign` an image.

I can split some of these pieces apart, but wanted to get this all working end-to-end, since a key goal was enabling e2e testing on KinD.

This follows a lot of the ideas from: https://github.com/mattmoor/kind-oidc

Related: #212
Fixes: #194

Signed-off-by: Matt Moore <mattomata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant