pkg/api/client.RootCert should use the provided *http.Client

[imjasonh]

Description

RootCert calls http.Get, which uses the default client:

fulcio/pkg/api/client.go

Line 138 in 56c15d6

resp, err := http.Get(endpoint.String())

Contrast with SigningCert, which uses the provided *http.Client if one was provided:

fulcio/pkg/api/client.go

Line 97 in 56c15d6

resp, err := c.client.Do(req)

This means that if WithTimeout or WithUserAgent are called, these will be ignored when fetching the root cert. If future client options are added, these would likely also be ignored.

If this is unintentional, I can send a PR to fix it.

[imjasonh]

Looks like it was added in #290 cc @vaikas

[vaikas]

Oops, great call @imjasonh thanks! Are you sending a PR or do you want me to clean up my own messes? :)

[imjasonh]

Oops, great call @imjasonh thanks! Are you sending a PR or do you want me to clean up my own messes? :)

I got you: #502