Use provided HTTP client instead when fetching root cert #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jasonhall@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #502 +/- ##
==========================================
- Coverage 47.97% 47.89% -0.09%
==========================================
Files 14 14
Lines 1063 1067 +4
==========================================
+ Hits 510 511 +1
- Misses 480 482 +2
- Partials 73 74 +1
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 2, 2022
haydentherapper
pushed a commit
to haydentherapper/fulcio
that referenced
this pull request
Apr 6, 2022
Signed-off-by: Jason Hall <jasonhall@redhat.com>
haydentherapper
pushed a commit
to haydentherapper/fulcio
that referenced
this pull request
Apr 9, 2022
Signed-off-by: Jason Hall <jasonhall@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Hall jasonhall@redhat.com
Fixes #501
@vaikas