config: Allow alternative kubernetes.default.svc DNS names. #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes scaffolding will fail due to minor differences in the local OIDC issuers, even though these are functionally the same. This adds support for https://kubernetes.default.svc.cluster.local, and will load the cluster CA to the transport if either are present. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 58.23% 58.33% +0.09%
==========================================
Files 50 50
Lines 3053 3053
==========================================
+ Hits 1778 1781 +3
+ Misses 1116 1114 -2
+ Partials 159 158 -1
|
cpanato
approved these changes
Jul 24, 2023
| t := originalTransport.(*http.Transport).Clone() | ||
| t.TLSClientConfig.RootCAs = rootCAs | ||
| http.DefaultTransport = t | ||
| } else { |
There was a problem hiding this comment.
@wlynch Can you confirm that this else condition is no longer needed? I don't see a place where we overwrote it previously, but I don't have context into why it was there initially.
|
Bump, is this still needed? |
|
I actually don't know 😅 This was partially in response to some of the issues we've been seeing in scaffolding. I'll close this for now, we can always reopen 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes scaffolding will fail due to minor differences in the local OIDC issuers, even though these are functionally the same.
This adds support for https://kubernetes.default.svc.cluster.local, and will load the cluster CA to the transport if either are present.
Also removes the
originalTransportglobal var, since it isn't being used in a meaningful way.cc @vaikas
Release Note
Adds support for alternative local-kubernetes OIDC issuer DNS names (e.g. kubernetes.default.svc vs kubernetes.default.svc.cluster.local)
Documentation