Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding ci provider for meta-issuers #1767

Conversation

javanlacerda
Copy link
Contributor

Summary

It set the ci-provider field for meta-issuers

Release Note

Documentation

Signed-off-by: Javan lacerda <javanlacerda@google.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (cf238ac) to head (f06f32f).
Report is 175 commits behind head on main.

Files Patch % Lines
pkg/identity/ciprovider/principal.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   57.93%   50.31%   -7.63%     
==========================================
  Files          50       70      +20     
  Lines        3119     4180    +1061     
==========================================
+ Hits         1807     2103     +296     
- Misses       1154     1844     +690     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.add-ciprovider-for-meta-issuers branch from 8432773 to 9389e38 Compare August 15, 2024 17:58
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.add-ciprovider-for-meta-issuers branch from 9389e38 to 8403201 Compare August 15, 2024 18:10
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@haydentherapper haydentherapper merged commit 8acbceb into sigstore:main Aug 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants