Sync proto #1849
Sync proto #1849
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 57.93% 49.09% -8.84%
==========================================
Files 50 70 +20
Lines 3119 5204 +2085
==========================================
+ Hits 1807 2555 +748
- Misses 1154 2415 +1261
- Partials 158 234 +76 ☔ View full report in Codecov by Sentry. |
| @@ -1,6 +1,6 @@ | |||
| module github.com/sigstore/fulcio/hack/tools | |||
|
|
|||
| go 1.22.5 | |||
| go 1.23 | |||
There was a problem hiding this comment.
should we keep this synced with go.mod in project root dir?
There was a problem hiding this comment.
no strong options as this will get any patch release of go
There was a problem hiding this comment.
Is there general guidance on go 1.x.y vs go 1.x? We used to only do the latter, and then at some point, Go forced us to specify each patch release.
There was a problem hiding this comment.
that will say the minimum go version, if we pin to a patch for example go 1.22.8 it will not build with go1.22.7, but if we say go 1.22 it will work for all
but if one of the deps have a patch pinned i think that will come the toolchain that will force to use a pinned go version
that is my understanding
No description provided.