Fix the SCT header return value from the API to base64 encode it. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaikas
reviewed
Dec 21, 2021
pkg/api/ca.go
Outdated
| @@ -203,7 +203,7 @@ func signingCert(w http.ResponseWriter, req *http.Request) { | |||
| } | |||
|
|
|||
| // Set the SCT and Content-Type headers, and then respond with a 201 Created. | |||
| w.Header().Add("SCT", string(sctBytes)) | |||
| w.Header().Add("SCT", base64.RawStdEncoding.EncodeToString(sctBytes)) | |||
There was a problem hiding this comment.
Since the client uses StdEncoding when decoding, should this use that too?
I don't actually know what's correct here - but the current client expects it to be base64 encoded. We could keep it "raw", but then we have to fix the client that's currently in cosign. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
|
/lgtm |
vaikas
approved these changes
Dec 21, 2021
|
I'm also adding a test for this as part of #289 |
vaikas
added a commit
to vaikas/fulcio
that referenced
this pull request
Dec 21, 2021
* Add tests for exercising STL * Fix sigstore#289 * Validates that the new STL tests failed unless backporting sigstore#288 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
dlorenc
pushed a commit
that referenced
this pull request
Dec 21, 2021
bobcallaway
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't actually know what's correct here - but the current client expects
it to be base64 encoded. We could keep it "raw", but then we have to fix the client
that's currently in cosign.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Summary
Ticket Link
Fixes
Release Note