Support intermediate CA with fileca backend
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmith5
force-pushed
the
fileca-intermediates
branch
4 times, most recently
from
44ae553
to
bb427eb
Compare
|
Thanks for the timely review @haydentherapper! I'll add the len(chain) = 3 test case and modify the cert verification logic soon :D |
nsmith5
force-pushed
the
fileca-intermediates
branch
from
bb427eb
to
98d3235
Compare
haydentherapper
approved these changes
Jan 14, 2022
nsmith5
force-pushed
the
fileca-intermediates
branch
from
98d3235
to
11a37a2
Compare
nsmith5
force-pushed
the
fileca-intermediates
branch
2 times, most recently
from
6b1589e
to
cc60c9d
Compare
|
The codeql check is failing everywhere, so you can ignore that one! |
nsmith5
force-pushed
the
fileca-intermediates
branch
from
cc60c9d
to
990ef56
Compare
haydentherapper
approved these changes
Jan 17, 2022
|
Sweeeet! Thanks for the comprehensive review. It really taught me a lot! I really appreciate the time you put into it ❤️ |
bobcallaway
approved these changes
Jan 18, 2022
Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
nsmith5
force-pushed
the
fileca-intermediates
branch
from
990ef56
to
e8d79db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for an intermediate CA using the fileca backend
Ticket Link
Fixes #300
Release Note