Allow parameterized application/json content types #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
allow-parametered-content-type
branch
2 times, most recently
from
1decee0
to
41e153e
Compare
|
code looks fine, anyway we could add some unit testing around this? |
|
lol, I was afraid and waiting for someone to ask that. I'll go restructure this. |
loosebazooka
commented
Feb 4, 2022
pkg/api/ca.go
Outdated
| gotContentType, _, perr := mime.ParseMediaType(contentTypeHeader) | ||
| if perr != nil { | ||
| err := fmt.Errorf("could not parse Content-Type %q", contentTypeHeader) | ||
| handleFulcioAPIError(w, req, http.StatusUnsupportedMediaType, err, err.Error()) |
There was a problem hiding this comment.
looks like I missed a return here too
Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
allow-parametered-content-type
branch
from
41e153e
to
82b9945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compatibility issue where content-type "application/json; charset=UTF-8" wasn't allowed.