Return an error if we fail get get the Root cert. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well, that's interesting. UT passes just fine on local machine :) |
mattmoor
approved these changes
Feb 17, 2022
mattmoor
reviewed
Feb 17, 2022
pkg/api/api_test.go
Outdated
| // TestMissingRootFails creates a bad Google CA and tests that the client | ||
| // gets an error returned to it. | ||
| func TestMissingRootFails(t *testing.T) { | ||
| caClient, err := v1.NewCertAuthorityService(context.Background(), "non-existent") |
There was a problem hiding this comment.
This isn't going to work in CI 😞
There was a problem hiding this comment.
Yeah, I will sort out a different test for it.
Fixes: sigstore#415 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
dlorenc
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #415
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Return an error if we fail to get the Root Certificate.
Ticket Link
Fixes #415
Release Note