Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indent to fix yaml error #434

Merged
merged 1 commit into from
Feb 23, 2022
Merged

add indent to fix yaml error #434

merged 1 commit into from
Feb 23, 2022

Conversation

bobcallaway
Copy link
Member

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@cpanato
Copy link
Member

cpanato commented Feb 23, 2022

i was thinking if we can run some yaml lint to catch those things

@mattmoor mattmoor merged commit b79432c into sigstore:main Feb 23, 2022
@mattmoor
Copy link
Member

@cpanato Kenny found an action linter we just started running downstream: https://github.com/chainguard-dev/actions/blob/4ba8d060251254fc0e65500a8d3a90013a22a8d7/.github/workflows/actionlint.yaml#L20-L21

Not sure if would catch this, but it sure is annoying that these fail so quietly. Apologies for the break 🤦

@k4leung4
Copy link
Contributor

I tested yaml in their playground, it would have caught it.
playground at https://rhysd.github.io/actionlint/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants