Refactor x509 extension embedding logic #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 36.67% 41.07% +4.39%
==========================================
Files 19 20 +1
Lines 1445 1473 +28
==========================================
+ Hits 530 605 +75
+ Misses 855 800 -55
- Partials 60 68 +8
Continue to review full report at Codecov.
|
haydentherapper
previously approved these changes
May 9, 2022
nsmith5
force-pushed
the
refactor-extensions
branch
from
f74c68d
to
f3acb10
Compare
Adds a new extensions structure that documents the global set of extensions added to our certificates and a method to render that data into extensions. Signed-off-by: Nathan Smith <nathan@chainguard.dev>
nsmith5
force-pushed
the
refactor-extensions
branch
from
f3acb10
to
10ce525
Compare
haydentherapper
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new extensions structure that documents the global set of
extensions added to our certificates and a method to render that data
into extensions.
Ticket Link
Related to #275
Release Note