Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Subject field from CodeSigningCertificate #568

Merged
merged 1 commit into from
May 11, 2022

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 11, 2022

Summary

Removes the Subject field from CodeSigningCertificate and CodeSigningPreCertificate as the field is unused in the rest
of the code base. This change helps to remove the usage of challenges.ChallengeResult in general as we move to the newer
identity issuer abstraction.

Bonus: Check out that git commit signature! Signed by Fulcio :D

Release Note

NONE

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #568 (579494a) into main (4ebe287) will increase coverage by 0.30%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   43.17%   43.47%   +0.30%     
==========================================
  Files          20       20              
  Lines        1473     1472       -1     
==========================================
+ Hits          636      640       +4     
+ Misses        766      762       -4     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
pkg/ca/googleca/v1/googleca.go 50.43% <0.00%> (ø)
pkg/ca/x509ca/common.go 34.34% <0.00%> (ø)
pkg/ca/intermediateca/intermediateca.go 72.30% <66.66%> (-0.22%) ⬇️
pkg/ca/fileca/watch.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebe287...579494a. Read the comment docs.

@nsmith5 nsmith5 mentioned this pull request May 11, 2022
@haydentherapper haydentherapper merged commit c166938 into sigstore:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants