Refactor challenge verification #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve got to prep for a presentation, so I’ll take a look at this first thing Monday. |
nsmith5
force-pushed
the
refactor-challenge-verification
branch
from
46fab85
to
3fde015
Compare
nsmith5
force-pushed
the
refactor-challenge-verification
branch
from
3fde015
to
62efc87
Compare
added 2 commits
May 16, 2022 09:26
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
There are two challenges a caller can use to prove they possess their private key: - Submit a CSR - Sign the subject or email from their ID token Previously the logic to verify these two types of challenges was interweaved. This work splits the verification into two different branches and groups the logic of each type of verification together. Signed-off-by: Nathan Smith <nathan@chainguard.dev>
nsmith5
force-pushed
the
refactor-challenge-verification
branch
from
62efc87
to
57dbda7
Compare
haydentherapper
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The challenge verification logic is sort of mixed up with the OIDC token parsing at the moment. This work makes two changes to this logic to make it a little easier to understand (there is one commit per change so you can read one at a time if desired)
ExtractSubjectinto two seperate things