Add interface for certs/signer fetching to remove mutex #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all but the file CA implementation, locking when retrieving the certs/signer is not necessary. This refactors the intermediate CA struct by embedding an interface to fetch the certs/signer. Each CA type can use either the basic structure that simply returns certs/signer, or one that has a mutex to protect access to the variables. Also small test fix - go 1.18 checks for duplicate extensions in certs now, so I had to regenerate a test certificate. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
key-dist
branch
from
b732504
to
bf55b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all but the file CA implementation, locking when retrieving the
certs/signer is not necessary. This refactors the intermediate CA struct
by embedding an interface to fetch the certs/signer. Each CA type can
use either the basic structure that simply returns certs/signer, or one
that has a mutex to protect access to the variables.
Also small test fix - go 1.18 checks for duplicate extensions in certs
now, so I had to regenerate a test certificate.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note