-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump sigstore/sigstore from 1.3.1 to 1.4.0 #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing lgtm, seems like something changed?
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
To fix the test, update https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server_test.go#L959 and https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server_test.go#L1366 to be PublicKeyPEMType. |
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 54.18% 54.05% -0.14%
==========================================
Files 36 36
Lines 2257 2257
==========================================
- Hits 1223 1220 -3
- Misses 942 944 +2
- Partials 92 93 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thanks for pointing me in the right direction. fixed. |
Signed-off-by: Kenny Leung kleung@chainguard.dev
Summary
bump sigstore/sigstore from 1.3.1 to 1.4.0
Release Note
NONE
Documentation