Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more self tests to CI #2

Closed
tetsuo-cpp opened this issue Jul 3, 2022 · 2 comments
Closed

Add more self tests to CI #2

tetsuo-cpp opened this issue Jul 3, 2022 · 2 comments
Assignees
@tetsuo-cpp
Milestone
Stable release (1.0)

Comments

@tetsuo-cpp
Copy link
Collaborator

Let's add more invocations of sigstore-python that exercise the different CLI options. At the moment, we just sign ./tests/artifact.txt in the prod and staging instances.
@tetsuo-cpp tetsuo-cpp self-assigned this Jul 3, 2022
@tetsuo-cpp tetsuo-cpp added this to the Stable release (1.0) milestone Aug 1, 2022
@tetsuo-cpp tetsuo-cpp mentioned this issue Aug 5, 2022
Merged
@woodruffw
Copy link
Member

I added some "xfail" style tests with #37, and we should probably add some more (at least one for each invocation of _fatal_help in the action).

@woodruffw woodruffw mentioned this issue Nov 28, 2022
Merged
@woodruffw
Copy link
Member

I think we can consider this complete for now -- there are a handful of settings that we don't explicitly test (like the fulcio-url and rekor-url settings), but these map directly to their sigstore CLI equivalents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetsuo-cpp tetsuo-cpp

Labels
None yet
Projects
None yet
Milestone
Stable release (1.0)
Development

No branches or pull requests
2 participants
@woodruffw @tetsuo-cpp