-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty inputs with release artifacts #110
Allow empty inputs with release artifacts #110
Conversation
…to true Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Thanks @JeanChristopheMorinPerso! I'm reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! One nitpick.
Yeah, unfortunately tests here will probably be a PITA. I'm okay with skipping them for now; if we hit bugs on this path in the future, we'll investigate mocking up a release environment to test in. |
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JeanChristopheMorinPerso!
Summary
Resolves #109
Some projects don't generate artifacts as part of their releases but would still like to have their source archives attached to releases signed (using
release-signing-artifacts
). This was previously not possible to do with this action becauseinputs
was a required input.With this pull request, it will be possible to not specify
inputs
and userelease-signing-artifacts
for releases:Note that
inputs
is still required ifrelease-signing-artifacts
is nottrue
and the event type is notrelease
. In this case, the action will raise a descriptive error.Release Note
inputs
was made optional when the event type isrelease
andrelease-signing-artifacts
is true.Documentation
I adjusted the README to reflect the changes.
Tests
I'm not sure if I should add tests or not. I tested locally different scenarios and also ran the
selftest
workflow in my fork (https://github.com/JeanChristopheMorinPerso/gh-action-sigstore-python/actions/runs/7949857773), but I'm not sure how to properly test the release scenario without releasing a fork of the action...