Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: sigstore ~3.0 #140

Merged
merged 5 commits into from
Jun 17, 2024
Merged

requirements: sigstore ~3.0 #140

merged 5 commits into from
Jun 17, 2024

Conversation

woodruffw
Copy link
Member

The 3.x series is out. Let's see what breaks!

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw self-assigned this Jun 7, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

Looks good now. Key changes:

  • The default suffix change from .sigstore to .sigstore.json has taken effect; we should communicate this as part of the (major) release notes for this change.
  • The manual state options for Fulcio, Rekor, etc. instances have been fully removed. We could replace these with a new option for --trust-config, but there's been no user demand for it yet. So maybe in a subsequent release.

@woodruffw woodruffw marked this pull request as ready for review June 7, 2024 19:38
@woodruffw woodruffw requested a review from jku June 7, 2024 19:38
@woodruffw
Copy link
Member Author

(NB: This doesn't enable the DSSE parts of sigstore-python, which are in 3.x. Enabling those with appropriate settings will probably require more design thought.)

@webknjaz
Copy link

webknjaz commented Jun 9, 2024

FTR, the 2.x stream prints out deprecation warnings that would be fixed in 3.x per my understanding:

/home/runner/.local/lib/python3.10/site-packages/sigstore/sign.py:141: CryptographyDeprecationWarning: Properties that return a naïve datetime object have been deprecated. Please switch to not_valid_after_utc.
  not_valid_after = self.__cached_signing_certificate.cert.not_valid_after
/home/runner/.local/lib/python3.10/site-packages/sigstore/sign.py:141: CryptographyDeprecationWarning: Properties that return a naïve datetime object have been deprecated. Please switch to not_valid_after_utc.
  not_valid_after = self.__cached_signing_certificate.cert.not_valid_after
/home/runner/.local/lib/python3.10/site-packages/sigstore/sign.py:141: CryptographyDeprecationWarning: Properties that return a naïve datetime object have been deprecated. Please switch to not_valid_after_utc.
  not_valid_after = self.__cached_signing_certificate.cert.not_valid_after

Perhaps, mention this in the change log as well?

@woodruffw
Copy link
Member Author

Hmm, it's actually strange that those are in 2.x -- the 2.x series of sigstore-python should be using a sufficiently new version of cryptography as well.

But yeah, if you're seeing them with one but not the other, I'll include it in the release notes 🙂

@webknjaz
Copy link

webknjaz commented Jun 9, 2024

I haven't tried. Just checked that you changed corresponding line in v3.

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@woodruffw woodruffw merged commit 9466100 into main Jun 17, 2024
30 checks passed
@woodruffw woodruffw deleted the ww/bump-sigstore branch June 17, 2024 14:18
@woodruffw
Copy link
Member Author

Thanks both! I'll prep the changelog and release today.

(Longer-term, the value of this action is now a bit murky, since GitHub has attestation support directly built in with official actions. But that can be a separate discussion...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants