ci, action: address zizmor findings, bump versions #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
commented
Oct 14, 2025
| SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }} | ||
| container: | ||
| image: semgrep/semgrep | ||
| image: semgrep/semgrep:1.138.0 |
There was a problem hiding this comment.
Note: I pinned this based on https://hub.docker.com/r/semgrep/semgrep/tags, but we should really be fully hash-pinning this. Unfortunately, I don't think any tools do a great job of updating Docker image references in GHA (maybe zizmor should).
Alternatively, I think we could remove this workflow entirely -- IMO Semgrep hasn't provided a ton of value in this repo, and I honestly can't remember why we added it 😅
jku
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a chore PR, addressing a bunch of zizmor findings and pin bumps.
Also fixes a bunch of broken version comments, presumably due to bugs in Dependabot.