Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: implement and document bundle-only #49

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Feb 15, 2023

Summary

This changeset resolves #47 by adding the bundle-only setting, which disables the upload of .crt and .sig outputs.

Release Note

Implemented the bundle-only setting, which disables upload of .crt and .sig artifacts when used in conjunction
with upload-signing-artifacts and release-signing-artifacts.

Documentation

Documented in the README!

Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
woodruffw previously approved these changes Feb 15, 2023
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; let's go ahead and configure it in the release.yml workflow as well!

@tnytown
Copy link
Collaborator Author

tnytown commented Feb 15, 2023

The respective outputs will be uploaded when certificate or signature are specified along with this setting, but I don't see why someone would do that? I can add a check for that if we feel that it is necessary

Signed-off-by: Andrew Pan <a@tny.town>
@woodruffw
Copy link
Member

The respective outputs will be uploaded when certificate or signature are specified along with this setting, but I don't see why someone would do that? I can add a check for that if we feel that it is necessary

Yeah, I was thinking about that -- IMO it's fine as is, since passing certificate and signature explicitly imply that they want specific filenames for those outputs, and that doesn't make much sense unless they explicitly end up as artifacts/assets.

That being said I think we can safely drop those two settings entirely with the next major release -- they stick out a bit and add unnecessary complexity to the action.

@woodruffw woodruffw merged commit 607296a into sigstore:main Feb 15, 2023
@woodruffw
Copy link
Member

LGTM! I'll do a prerelease with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a setting to disable .crt and .sig outputs
2 participants