Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: upload artifact being signed for #55

Merged
merged 2 commits into from
Mar 23, 2023
Merged

action: upload artifact being signed for #55

merged 2 commits into from
Mar 23, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Mar 23, 2023

Summary

Resolves #54.

Release Note

The action now uploads the original artifacts from inputs alongside their signatures.

@tnytown
action: upload artifact being signed for
6838c6e 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown requested a review from woodruffw March 23, 2023 17:03
@tnytown tnytown self-assigned this Mar 23, 2023
woodruffw
woodruffw reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; let's also add a selftest to confirm that we're doing this correctly.

@tnytown
workflows/selftest: confirm presence of artifacts
335dd26 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown requested a review from woodruffw March 23, 2023 19:03
woodruffw
woodruffw approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit 3548791 into sigstore:main Mar 23, 2023
This was referenced Mar 23, 2023
Merged
Merged
@woodruffw woodruffw mentioned this pull request Mar 23, 2023
Merged
@tnytown tnytown mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

@tnytown tnytown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Artifact/release asset upload should include the signed inputs
2 participants
@tnytown @woodruffw