Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: accommodate Windows #72

Merged
merged 13 commits into from
Aug 7, 2023
Merged

action: accommodate Windows #72

merged 13 commits into from
Aug 7, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Aug 2, 2023 •
edited
Loading

Runs the selftest CI on Windows as well, to keep us from regressing going forwards.

Closes #71.

@woodruffw
action: accommodate Windows
805b3cd 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
selftest: macOS, Windows
8bdd726 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
selftest: explicit python version
aa138ec 
Needed for macOS, Windows (probably)

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
action: force bash for action.py invocation as well
1c3a332 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Revert "action: force bash for action.py invocation as well"
6ed8ade 
This reverts commit 1c3a332.
@woodruffw
action: Windows force UTF-8
9545ee1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
action: hackety hack
f53aa17 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
action: random delim
30aee4f 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
action: oops
08a360c 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
selftest: shell: bash
c762893 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
ci: loosen python constraint
9cd1286 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
action: use os.urandom
8bb6699 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review August 2, 2023 19:44
@woodruffw woodruffw self-assigned this Aug 2, 2023
@woodruffw woodruffw mentioned this pull request Aug 2, 2023
Closed
tnytown
tnytown approved these changes Aug 2, 2023
View reviewed changes
action.yml Show resolved Hide resolved
tetsuo-cpp
tetsuo-cpp reviewed Aug 3, 2023
View reviewed changes
action.py Outdated Show resolved Hide resolved
tetsuo-cpp
tetsuo-cpp previously approved these changes Aug 3, 2023
View reviewed changes
@woodruffw
action: document random delimiter
3a4eed0 
Signed-off-by: William Woodruff <william@trailofbits.com>
tetsuo-cpp
tetsuo-cpp approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit 0f34eb3 into main Aug 7, 2023
20 checks passed
@tetsuo-cpp tetsuo-cpp deleted the ww/windows-accomodations branch August 7, 2023 02:04
@esev esev mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

@tnytown tnytown tnytown approved these changes

Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

action.py: No such file or directory
3 participants
@woodruffw @tnytown @tetsuo-cpp