-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: bump sigstore-python #97
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a fix looks correct to me.
I suppose an argument could be made to pin these exactly as well (==2.1.0) -- but I'm not sure about it and that sounds like a potential separate issue.
Yeah, I've gone back and forth on that -- on one hand the workflow should probably as hermetic/reproducible as possible, and on the other doing an exact pin means that every single I don't have any strong opinions here, though -- if best practice on GHA is to make workflows hermetic, then we should do that 🙂 |
I think as long as there's enough information to determine what version was used in a given action run, it would be preferable for this to be unpinned or loosely pinned. |
Makes sense. We currently list the version as part of |
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
I've made the sigstore-python version a bit more prominent, example here: https://github.com/sigstore/gh-action-sigstore-python/actions/runs/7201147355/job/19616624805#step:4:125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Seals off the resolution bug we saw in #94.
I'll do a release after this.