Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom roles #118

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

jku
Copy link
Member

@jku jku commented Feb 1, 2024

root-signing-staging (and later root-signing) is planning to use a custom role for the online signing system.

Add support for creating a custom role in the org so that a role can be defined and assigned to sigstore-bot for those repositories.


Fixes #117

root-signing-staging (and later root-signing) is planning to use a
custom role for the online signing system.

Add support for creating a custom role in the org so that a role can
be defined and assigned to sigstore-bot for those repositories.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Copy link
Member Author

jku commented Feb 1, 2024

Go is not my native language and I'm not too familiar with this setup... My assumption is that I can't really try this code before it's merged and there is a PR to sigstore/community -- please let me know if there's another way I should consider.

@jku jku marked this pull request as ready for review February 1, 2024 09:49
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

thanks
lets try that

@cpanato cpanato merged commit adec712 into sigstore:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom roles
3 participants