Add ability to disable namespace opt-in #268
Conversation
slimm609
force-pushed
the
namespace_optIn_flag
branch
3 times, most recently
from
f4c66ce
to
c616289
Compare
slimm609
force-pushed
the
namespace_optIn_flag
branch
from
73dea8a
to
ae2f67f
Compare
|
@slimm609 Sorry, could you rebase these changes again ? I think this PR got lost somehow. Happy to help you to get it in. |
- add the ability to disable opt-in support for namespace validation and enforce on across the entire cluster Signed-off-by: slimm609 <dbrian@vmware.com>
Signed-off-by: slimm609 <dbrian@vmware.com>
slimm609
force-pushed
the
namespace_optIn_flag
branch
2 times, most recently
from
626f470
to
9159806
Compare
Signed-off-by: slimm609 <dbrian@vmware.com>
slimm609
force-pushed
the
namespace_optIn_flag
branch
from
9159806
to
13d51cf
Compare
|
@hectorj2f rebased |
| @@ -0,0 +1,115 @@ | |||
| {{ template "chart.header" . }} | |||
There was a problem hiding this comment.
Q: Why do we need this file ?
There was a problem hiding this comment.
You don't have to do helm-docs --dry-run then modify the README.md each time. Instead you run helm-docs and it generates the entire file for you.
There was a problem hiding this comment.
Also makes it easy to validate because if helm-docs generates a diff, then you know it wasn't properly updated.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sgtm, what do you think @cpanato ?
There was a problem hiding this comment.
As mentioned, let's revert this change and keep only the opt-in functionality.
Signed-off-by: slimm609 <dbrian@vmware.com>
Signed-off-by: slimm609 <dbrian@vmware.com>
|
@slimm609 Could we remove the helm docs addition as part of this PR? We want to evaluate it's benefits in a separate PR. |
| ## More info | ||
|
|
||
| You can find more information about the policy-controller in [here](https://docs.sigstore.dev/policy-controller/overview/). | ||
|
|
||
| ---------------------------------------------- | ||
| Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0) |
There was a problem hiding this comment.
Let's move this change to a separate PR, so we can address the issue itself.
|
@hectorj2f @slimm609 Any chance to promote it? 🥺 |
Description of the change
Existing or Associated Issue(s)
sigstore/policy-controller#66
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. THe helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the contentct lintcommand