Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scaffold tuf secret paths default values #681

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

falcorocks
Copy link
Contributor

Description of the change

Tuf chart has been updated to version 0.1.9 to resolve a bug in the default path of sigstore PKI secrets (links below). Tuf new version has been updated in the scaffold chart, however the default values of the scaffold chart were not updated. This PR fixes the default value (which otherwise override the previous fix, unless one knows about it :)

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@haydentherapper
Copy link
Contributor

Can you sign the DCO?

Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
@falcorocks
Copy link
Contributor Author

falcorocks commented Dec 6, 2023

@haydentherapper Done, apologies... it's my first PR :)

Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@k4leung4 k4leung4 merged commit 2070356 into sigstore:main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaffold chart default values need to be updated to fix tuf secrets names mismatch
3 participants