Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for DIRSHA256 #108

Closed

Conversation

laurentsimon
Copy link
Collaborator

No description provided.

Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon laurentsimon force-pushed the feat/dirsha256-readme branch from 1c97ae4 to 30e98f7 Compare January 17, 2024 01:22
@laurentsimon
Copy link
Collaborator Author

/cc @bobcallaway

Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
smeiklej
smeiklej previously approved these changes Jan 17, 2024
Copy link
Collaborator

@smeiklej smeiklej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left a few minor comments.

DIRSHA256.md Outdated Show resolved Hide resolved
DIRSHA256.md Outdated Show resolved Hide resolved
DIRSHA256.md Outdated Show resolved Hide resolved
DIRSHA256.md Outdated Show resolved Hide resolved
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
Copy link
Collaborator Author

@mihaimaruseac lmk if you have further comments

mihaimaruseac
mihaimaruseac previously approved these changes Jun 18, 2024
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(testing approval rights)

@mihaimaruseac mihaimaruseac dismissed their stale review June 18, 2024 16:41

Test passed

@mihaimaruseac
Copy link
Collaborator

Since we're doing manifest hashing, I think we no longer need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants